Adds a fix and a test to cover Powershell keywords#20
Merged
adfoster-r7 merged 1 commit intomasterfrom Aug 1, 2025
Merged
Conversation
cgranleese-r7
force-pushed
the
adds-test-for-powershell-keywords
branch
from
648b5e7 to
28c0703
Compare
cgranleese-r7
changed the title
cgranleese-r7
changed the title
adfoster-r7
reviewed
Aug 1, 2025
| def forbid_id?(ident = nil) | ||
| ident.nil? or @opts[:forbidden].any? {|f| f.match(/^#{ident}$/i) } | ||
| return true if ident.nil? | ||
| @opts[:forbidden].any? { |f| f.casecmp?(ident) } |
Contributor
There was a problem hiding this comment.
For future travellers: if ident has $ in it or other inbuilt regex chars, it caused issues with the old implementation
adfoster-r7
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a fix and a test to cover Powershell keywords.
Verification